[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

[Anatoly Trosinenko via Phabricator via cfe-commits]

atrosinenko added a comment.

@samsonov Something strange happens with the compiler-rt tests: when this patch was initially uploaded, the tests were failed with seemingly unrelated failures: B59287 <https://reviews.llvm.org/B59287>. Some tests are broken upstream, I concluded.

Today I have rebased the patch onto current master branch, and the tests passed, as expected: B60775 <https://reviews.llvm.org/B60775>. Right, the tests were actually broken upstream, I concluded.

Then I rebased some other my patch that were failing with similar messages: D81408 <https://reviews.llvm.org/D81408>. There may be some clang-format issues but the thing I not expected were the same test failures I have seen here: B60811 <https://reviews.llvm.org/B60811>. Even more: the B60775 <https://reviews.llvm.org/B60775> build is marked "Passed", but when I click on "Build 73581 pre-merge checks (buildkite)" and then go to "Exterenl Link: buildkite build" it shows Linux build as failed.

Returning to the original test failures:

  linux > cfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::anon-namespace.cpp

They contain the following error message:

  ld.lld: error: Invalid summary version 8. Version should be in the range [1-7].

This message is seemingly printed by

name=llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  if (Version < 1 || Version > ModuleSummaryIndex::BitcodeSummaryVersion)
    return error("Invalid summary version " + Twine(Version) +
                 ". Version should be in the range [1-" +
                 Twine(ModuleSummaryIndex::BitcodeSummaryVersion) +
                 "].");

with `ModuleSummaryIndex::BitcodeSummaryVersion` defined to be 8 in current version of repository.

When trying to reproduce this on my local machine, I built LLVM together with clang, compiler-rt and lld. The tests passed. Then I modified the `.script` file to directly refer to locally built `bin/FileCheck`, `bin/not`, etc. and added `-v` option. Turned out, the Clang driver invokes `/path/to/build/directory/bin/ld.lld` but after `chmod -x bin/lld` it silently falls back to `/usr/bin/ld.lld`. Finally, the build log contains line "-- lld project is disabled" suggesting it does use the system-provided ld.lld that prints this warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81282/new/

https://reviews.llvm.org/D81282