[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

[Valeriy Savchenko via Phabricator via cfe-commits]

vsavchenko marked an inline comment as done.
vsavchenko added inline comments.


================
Comment at: clang/utils/analyzer/projects/box2d/run_static_analyzer.cmd:1
+cmake . -DCMAKE_BUILD_TYPE=Release -Bbuild -GNinja
+cmake --build build
----------------
NoQ wrote:
> Is there a flag to enable assertions or something like that? Usually we recommend people to enable assertions during analysis. It's also valuable to test that assertions are actually working.
> 
> Disabling assertions is in fact relatively good for reference results testing because all the false positives that they suppress are suddenly visible, and therefore the signal we receive from such testing is amplified significantly. But i wouldn't force such workflow on our solution-for-everyone because that requires a certain level of masochism in order to distinguish between "my patch introduced a false positive and it's bad" and "my patch introduced a false positive but it would have been suppressed by assertions and we do actually want to emit the warning in absence of assertions so it's good".
CMake doesn't have a unified solution for "Release with assertions" type of build.  It is usually done on per-project basis (like in LLVM).  I guess rather than searching for such a flag for every project, we can indeed change it to **Debug**.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81592/new/

https://reviews.llvm.org/D81592