[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 18 07:42:06 PDT 2020
NoQ added a comment.
Nice catch!
================
Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:383
+ # when directory name starts with the letter `l`.
+ if sys.platform == 'win32':
+ # Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`,
----------------
Behavior of this script should not depend on the host platform. Neither should it depend on the target platform if the graph is obtained via cross-compilation. It should only depend on the graph itself, as it's a simple dot file converter. The graph itself may, of course, depend on the target platform (maybe even on the host platform).
So it sounds like this fix should be on the C++ side.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82092/new/
https://reviews.llvm.org/D82092
More information about the cfe-commits
mailing list