[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added inline comments.


================
Comment at: clang/utils/analyzer/Dockerfile:10
+
+# newer CMake is required by LLVM
+RUN wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | tee /etc/apt/trusted.gpg.d/kitware.gpg >/dev/null
----------------
Ouch. I'm pretty bad with docker but is it possible to simply take a newer ubuntu?


================
Comment at: clang/utils/analyzer/Dockerfile:15
+# test system dependencies
+RUN apt-get update && apt-get install -y \
+    git \
----------------
Maybe put `apt-get update` on a separate line?

Also i think you mentioned offline that you want to freeze package versions here, can you add a FIXME?


================
Comment at: clang/utils/analyzer/entrypoint.py:31
+
+CMAKE_COMMAND = "cmake -G Ninja -DCMAKE_BUILD_TYPE=Release " \
+    "-DCMAKE_INSTALL_PREFIX=/analyzer -DLLVM_TARGETS_TO_BUILD=X86 " \
----------------
`-DLLVM_ENABLE_ASSERTIONS=ON`???


================
Comment at: clang/utils/analyzer/entrypoint.py:35
+    "-DLLVM_ENABLE_TERMINFO=OFF -DCLANG_ENABLE_ARCMT=OFF " \
+    "-DCLANG_ENABLE_STATIC_ANALYZER=ON"
+
----------------
I think this one's on by default but i guess it wouldn't hurt^^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81571/new/

https://reviews.llvm.org/D81571