[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

[Florian Hahn via Phabricator via cfe-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10792
 def err_builtin_matrix_pointer_arg: Error<
-  "%select{first|second}0 argument must be a pointer to a valid matrix element type">;
+  "%0 argument must be a pointer to a valid matrix element type">;
+
----------------
rjmccall wrote:
> You can write `%ord0` to get the diagnostic to print `1st`, `2nd`, etc, if that's acceptable vs. the spelled-out version.
Thanks for pointing me to `%ord`! I think most diagnostics for matrixes currently use the spelled out versions, but I'll prepare a follow-up patch to update all matrix diagnostics to consistently use `%ord`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72782/new/

https://reviews.llvm.org/D72782