[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.
Bruno Ricci via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 17 14:02:33 PDT 2020
riccibruno marked an inline comment as done.
riccibruno added inline comments.
================
Comment at: clang/test/SemaCXX/warn-unsequenced.cpp:313
+ //
+ // However SequenceChecker::VisitCXXConstructExpr only visit the arguments
+ // of the CXXConstructExpr and is not visiting the arguments of
----------------
riccibruno wrote:
> I meant "constructor initializers" instead, but I am not sure if they should be visited.
Ah, `struct X { int b = ++a; };` is not an aggregate in C++11 so I think this is fine.
I will remove the comment. Sorry for the spam.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81003/new/
https://reviews.llvm.org/D81003
More information about the cfe-commits
mailing list