[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

[Hiroshi Yamauchi via Phabricator via cfe-commits]

yamauchi added inline comments.


================
Comment at: clang/test/Driver/hip-toolchain-no-rdc.hip:164
+// LKONLY-NOT: llvm-link
+// LKONLY-NOT: opt
+// LKONLY-NOT: llc
----------------
yaxunl wrote:
> arsenm wrote:
> > yamauchi wrote:
> > > Hi, this test seems to fail for me because I happen to have the string "opt" in the "InstallDir" file path to the clang binary in my workstation, like
> > > 
> > > clang version 11.0.0 (https://github.com/llvm/llvm-project.git 6bc2b042f4a9e8d912901679bd4614d46f6fafed)
> > > Target: x86_64-unknown-linux-gnu
> > > Thread model: posix
> > > InstalledDir: /opt/llvm-project/build/bin
> > > 
> > > Is there a way for this check pattern to be refined to avoid this issue?
> > I think the negative checks aren't really necessary
> it can be changed to
> 
> // LINK-NOT: {{".*/opt"}}
Uploaded D82046 for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81861/new/

https://reviews.llvm.org/D81861