[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

[John McCall via Phabricator via cfe-commits]

rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10792
 def err_builtin_matrix_pointer_arg: Error<
-  "%select{first|second}0 argument must be a pointer to a valid matrix element type">;
+  "%0 argument must be a pointer to a valid matrix element type">;
+
----------------
You can write `%ord0` to get the diagnostic to print `1st`, `2nd`, etc, if that's acceptable vs. the spelled-out version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72782/new/

https://reviews.llvm.org/D72782