[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 17 11:18:48 PDT 2020


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/support/ThreadsafeFS.h:31
+  virtual ~ThreadsafeFS() = default;
+  /// Obtain a vfs::FileSystem with an arbitrary initial working directory.
+  virtual llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>
----------------
nit: blank line here


================
Comment at: clang-tools-extra/clangd/unittests/TestFS.h:36
 public:
-  // Prevent name hiding caused by the overload below.
-  using FileSystemProvider::getFileSystem;
-
   IntrusiveRefCntPtr<llvm::vfs::FileSystem> getFileSystem() const {
     return buildTestFS(Files, Timestamps);
----------------
this looks out of place - should it be inlined or renamed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81998/new/

https://reviews.llvm.org/D81998





More information about the cfe-commits mailing list