[PATCH] D81964: [clangd] Make use of preamble bounds from the patch inside ReplayPreamble

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 17 09:40:52 PDT 2020


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/Preamble.h:136
   std::vector<Inclusion> PreambleIncludes;
+  PreambleBounds PatchBounds = {0, false};
 };
----------------
sammccall wrote:
> nit: = {} seems less confusing.
> 
> Call this ModifiedBounds (or ModifiedPreambleBounds) as well? Not obvious to me what it is at the moment.
unfortunately `PreambleBounds` doesn't have a default constructor :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81964/new/

https://reviews.llvm.org/D81964





More information about the cfe-commits mailing list