[PATCH] D81912: [AST] Dump containsErrors bit for the Type.

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang/lib/AST/TextNodeDumper.cpp:205
 
+  if (T->containsErrors())
+    OS << " contains-errors";
----------------
hokein wrote:
> sammccall wrote:
> > IIRC in the expr case we used a color, does that make sense here?
> yeah, in the expr we use a color, but here I don't have a strong opinion -- the other dependence bits don't use color as well, so I'd keep consistent.
IMO it's at least as important to be consistent in how "contains-errors" is displayed, than it is that it's displayed in the same way as other bits.

I think this bit is special enough to warrant a color, but happy without... in that case we should drop it from exprs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81912/new/

https://reviews.llvm.org/D81912