[PATCH] D82011: [clangd] Don't mangle workdir-relevant driver path in compile commands

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:141
+    // Let's hope it's not a symlink.
+    if (llvm::any_of(Driver,
+                     [](char C) { return llvm::sys::path::is_separator(C); }))
----------------
I believe it would be clearer if you put it below, into `else if (ClangPath)` part.

i.e.
```
if (Absolute ...)
  ..
// If we couldn't find program and driver is just a filename, use clang dir
// FIXME: Note that Driver can still be relative to workdir even if it doesn't have any path separators.
// We should pass WD into here and try to make Driver absolute.
else if(ClangPath && !hasPathSeparators(Driver))
 ...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82011/new/

https://reviews.llvm.org/D82011