[PATCH] D81970: [Clang][Driver] Remove gold linker support for PS4 toolchain

[Paul Robinson via Phabricator via cfe-commits]

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

LGTM with one inline comment.



================
Comment at: clang/lib/Driver/ToolChains/PS4CPU.cpp:154
   const char *Exec =
-#ifdef _WIN32
-      Args.MakeArgString(ToolChain.GetProgramPath("orbis-ld.gold"));
-#else
-      Args.MakeArgString(ToolChain.GetProgramPath("orbis-ld"));
-#endif
+      Args.MakeArgString(ToolChain.GetProgramPath(LdName.c_str()));
 
----------------
Seems like you shouldn't need a temp variable LdName here?  The old code just passes the literal string directly:
`Args.MakeArgString(ToolChain.GetProgramPath("orbis-ld"));`



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81970/new/

https://reviews.llvm.org/D81970