[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic
Alexandre Ganea via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 16 14:19:10 PDT 2020
aganea added inline comments.
================
Comment at: clang/tools/driver/driver.cpp:518
+ CRC.DumpStackAndCleanupOnFailure = true;
+ CRC.RunSafely([&]() { abort(); });
}
----------------
The only concern I have is that a unrelated call stack will be printed.
Could you possibly add (and use here) a function along the lines of `emitBugReportMsg() { errs() << BugReportMsg; }`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81672/new/
https://reviews.llvm.org/D81672
More information about the cfe-commits
mailing list