[PATCH] D81966: [clang][module] Improve -Wincomplete-umbrella

Zixu Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 16 14:19:02 PDT 2020


zixuw created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
zixuw added reviewers: arphaman, rsmith, bruno.
Herald added a subscriber: dexonsmith.

Change the warning message for `-Wincomplete-umbrella` to report the
location of the umbrella header;
Add a fix-it hint to include uncovered headers in the umbrella header.

rdar://57095551


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81966

Files:
  clang/include/clang/Rewrite/Frontend/FrontendActions.h
  clang/lib/Frontend/Rewrite/FrontendActions.cpp
  clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp
  clang/lib/Lex/PPLexerChange.cpp
  clang/test/Modules/Inputs/incomplete-umbrella/normal-module/A1.h
  clang/test/Modules/Inputs/incomplete-umbrella/normal-module/A2.h
  clang/test/Modules/Inputs/incomplete-umbrella/normal-module/Umbrella.h
  clang/test/Modules/Inputs/incomplete-umbrella/normal-module/module.modulemap
  clang/test/Modules/incomplete-umbrella-fixit.m
  clang/test/Modules/incomplete-umbrella.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81966.271189.patch
Type: text/x-patch
Size: 8781 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200616/f5b1eb3c/attachment-0001.bin>


More information about the cfe-commits mailing list