[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

Lei Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 16 12:05:25 PDT 2020


lei added inline comments.


================
Comment at: clang/lib/Sema/DeclSpec.cpp:1155
+      // TODO: Update comment with correct Programming Interface Manual
+      // version once it is available. __int128 has also been added
+      // to vector bool for Power10.
----------------
saghir wrote:
> lei wrote:
> > Not sure what you mean here.
> Earlier comment had the Programming Interface Manual version number (PIM 2.1); asserting only char/int were valid with vector bool. 
> This patch adds __int128, so the comment needs to be updated with the latest version of the document once it is available.
Maybe need to add a TODO in all the sections of code, that you update, where it mentions PIM 2.1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81816/new/

https://reviews.llvm.org/D81816





More information about the cfe-commits mailing list