[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.

In D81641#2096114 <https://reviews.llvm.org/D81641#2096114>, @Fznamznon wrote:

> In D81641#2088446 <https://reviews.llvm.org/D81641#2088446>, @jdoerfert wrote:
>
> > OpenMP has the same restriction (no surprise I guess). Thanks for the ping!
> >
> > I think we do not emit diagnosis right now: https://godbolt.org/z/srDkXZ
> >  I think we also should diagnose this the same way, though it might be beyond the scope of this patch: https://godbolt.org/z/rRZFi4
>
>
> Alright, now the first case that you pointed is diagnosed as well.


Nice, thanks a lot!

> The second case is not diagnosed at all and I agree that it seems beyond the scope of this patch, because it looks like using of `#pragma omp task untied` doesn't trigger emission of deferred diagnostics.

Yeah, we need to track untied tasks first. Not as part of this though.

LGTM :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81641/new/

https://reviews.llvm.org/D81641