[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

[Lei Huang via Phabricator via cfe-commits]

lei added inline comments.


================
Comment at: clang/test/Parser/altivec-bool-128.c:2
+// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -target-feature +altivec -fsyntax-only -verify %s
+
----------------
saghir wrote:
> lei wrote:
> > test for `-mcpu=pwr10 -target-feature -power10-vector` and `-mcpu=pwr10 -target-feature -vsx`
> > same for cxx-altivec-bool-128.cpp
> This test basically checks that `VSX` needs to be enabled to have `vector bool __int128` type work.
Yes.   I am asking you to add a test to check that `power10-vector` is also needed to be enabled for this type to work.
eg. this type should not be enabled for `-mcpu=pwr10 -target-feature +vsx -target-feature -power10-vector`


================
Comment at: clang/test/Parser/p10-vector-bool-128.c:2
+// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -target-feature +vsx -fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -target-feature +altivec -target-feature +vsx -fsyntax-only -verify %s
+// expected-no-diagnostics
----------------
saghir wrote:
> lei wrote:
> > add run line for feature `cpu=pwr10 +power10-vector`
> Added `pwr10`.
> `vector bool __int128` type should work with `pwr10` and `vsx` enabled, `power10-vector` is not needed explicitly.
`cpu=pwr10 -vsx +power10-vector`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81816/new/

https://reviews.llvm.org/D81816