[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

Valentin Clement via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 16 09:21:57 PDT 2020


clementval added a comment.

In D81736#2093926 <https://reviews.llvm.org/D81736#2093926>, @jdoerfert wrote:

> Assuming this passes all the tests, it looks good to me. Let's wait a day or two for people to take a look though :)


@jdoerfert Sure let's wait a bit. I see a failure because of some clang-tidy warnings. How strongly should I fix them? I see some conflict with other code I see in TableGen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81736/new/

https://reviews.llvm.org/D81736





More information about the cfe-commits mailing list