[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

[Lei Huang via Phabricator via cfe-commits]

lei requested changes to this revision.
lei added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/lib/Sema/DeclSpec.cpp:1155
+      // TODO: Update comment with correct Programming Interface Manual
+      // version once it is available. __int128 has also been added
+      // to vector bool for Power10.
----------------
Not sure what you mean here.


================
Comment at: clang/lib/Sema/DeclSpec.cpp:1168
+          (!S.Context.getTargetInfo().hasFeature("vsx")) &&
+          (!S.Context.getTargetInfo().hasFeature("power10-vector")))
+        S.Diag(TSTLoc, diag::err_invalid_vector_bool_int128_decl_spec);
----------------
I think you should only check for "power10-vector" since this requires pwr10?  



================
Comment at: clang/test/Parser/altivec-bool-128.c:2
+// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -target-feature +altivec -fsyntax-only -verify %s
+
----------------
test for `-mcpu=pwr10 -target-feature -power10-vector` and `-mcpu=pwr10 -target-feature -vsx`
same for cxx-altivec-bool-128.cpp


================
Comment at: clang/test/Parser/p10-vector-bool-128.c:2
+// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -target-feature +vsx -fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -target-feature +altivec -target-feature +vsx -fsyntax-only -verify %s
+// expected-no-diagnostics
----------------
add run line for feature `cpu=pwr10 +power10-vector`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81816/new/

https://reviews.llvm.org/D81816