[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

Tue Jun 16 03:17:22 PDT 2020

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Thanks! Please mark as "NFC:" ("no functional change intended <https://twitter.com/barrelshifter/status/1045525721475497984>").

In D80517#2068336 <https://reviews.llvm.org/D80517#2068336>, @NoQ wrote:

> I guess this one's stuck on the discussion about whether we need to retain python2 support.

http://lists.llvm.org/pipermail/cfe-dev/2020-June/065805.html

> I don't think it actually matters for these scripts; 
>  it's not like they're run every day on an ancient buildbot that still 
>  doesn't have python3 (in fact as of now i don't think anybody uses them 
>  at all except us) but it sounds like in any case the only script that 
>  really needs to be python2 up to all possible formal requirements is 
>  `SATest.py` itself which is a trivial wrapper that parses some arguments 
>  and forwards them into docker; for everything else there's docker and 
>  you don't care what's within it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80517/new/

https://reviews.llvm.org/D80517