[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

Valeriy Savchenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 16 03:17:21 PDT 2020


vsavchenko marked 5 inline comments as done.
vsavchenko added inline comments.


================
Comment at: clang/test/Analysis/pch_crash.cpp:1
+// RUN: %clang_cc1 -triple x86_64-apple-macosx10.15.0 -emit-pch -o %t %s
+// RUN: %clang_analyze_cc1 -triple x86_64-apple-macosx10.15.0 -include-pch %t \
----------------
NoQ wrote:
> Just curious - did you double-check that only macos triples are affected? Maybe we should add a pair of run-lines without the triple, so that to automatically get coverage from buildbots on all platforms on which we have buildbots. Because the test should obviously pass on all platforms.
No, I didn't check that :(. I just know that this problem is not reproduced in docker (aka Ubuntu).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81916/new/

https://reviews.llvm.org/D81916





More information about the cfe-commits mailing list