[PATCH] D81737: docker images for mlir-nvidia

[Christian Kühnel via Phabricator via cfe-commits]

kuhnel added inline comments.


================
Comment at: buildbot/google/docker/build_deploy.sh:36
+
+docker build -t ${IMAGE_NAME}:latest -t ${IMAGE_NAME}:${VERSION} .
+
----------------
tra wrote:
> What if I happen to run it in a tree I haven't updated for a while? We probably don't want accidentally overwriting the currently used images with an out-of-date version. Should we check if the image with particular version already exists and inform the user that they are about to overwrite it?
> 
For that we do need to check the remote repository. So I'll keep that code.

It's surprisingly hard to come up with a solid way to tag images :)


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81737/new/

https://reviews.llvm.org/D81737