[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

Sander de Smalen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 16 01:04:30 PDT 2020


sdesmalen added inline comments.


================
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1
+// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve -target-feature +bf16 -fallow-half-arguments-and-returns -S -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -DSVE_OVERLOADED_FORMS -triple aarch64-none-linux-gnu -target-feature +sve -target-feature +bf16 -fallow-half-arguments-and-returns -S -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
----------------
stuij wrote:
> There should be no dependency on `-fallow-half-arguments-and-returns`. For bfloat we should use `-mfloat-abi hard`. Does this work for `-mfloat-abi softfp`?
`-fallow-half-arguments-and-returns` isn't strictly needed for this test, we just use the same RUN line for all the ACLE tests and we needed this for `__fp16` in some of the tests.

I don't believe that `-mfloat-abi softfp` is supported for AArch64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81304/new/

https://reviews.llvm.org/D81304





More information about the cfe-commits mailing list