[PATCH] D81732: [clang] Replace Decl::isUnconditionallyVisible() with Sema::isVisible()
Martin Böhme via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 15 22:00:15 PDT 2020
mboehme added a comment.
In D81732#2093260 <https://reviews.llvm.org/D81732#2093260>, @dblaikie wrote:
> Test case(s)?
Is there anything specific you have in mind?
This change should be behavior-preserving in the case where -fmodules-local-submodule-visibility isn't set, as evidenced by the existing tests, which continue to pass.
This change is a small step towards making -fmodules-local-submodule-visibility work for Objective-C, but unfortunately we're still a long way off from being able to turn this flag on; activating it for existing tests still causes them to fail because parts of AST are still using Decl::isUnconditionallyVisible() instead of Sema::isVisible(), and that's unfortunately harder to fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81732/new/
https://reviews.llvm.org/D81732
More information about the cfe-commits
mailing list