[PATCH] D81795: [clang] Enable -mms-bitfields by default for mingw targets

Mon Jun 15 13:14:35 PDT 2020

mstorsjo added a comment.

In D81795#2092878 <https://reviews.llvm.org/D81795#2092878>, @rjmccall wrote:

> Seems reasonable; GCC is the "system compiler" for this platform.   Does `isWindowsGNUEnvironment` exactly track the condition that GCC uses?  It's just MinGW, not Cygwin?

Yes: https://github.com/llvm/llvm-project/blob/d700237f1aa1bc05d584a0f50fdad89370e17987/llvm/include/llvm/ADT/Triple.h#L563-L574

And the corresponding change in GCC, https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=99e7ad2ec6a78a6a55cefaa952b57870594c08ae, only changed it for MinGW, not Cygwin (and the corresponding files for cygwin don't have that bit set).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81795/new/

https://reviews.llvm.org/D81795