[PATCH] D77592: [clang] Frontend components for the relative vtables ABI

[Erik Pilkington via Phabricator via cfe-commits]

erik.pilkington added inline comments.


================
Comment at: clang/lib/CodeGen/ConstantInitBuilder.cpp:132
+  return getRelativeOffsetToPosition(offsetType, target,
+                                     Builder.SelfReferences.size());
+}
----------------
Shouldn't this be `Builder.Buffer.size() - Begin` instead of `Builder.SelfReferences.size()`? If a record had a mix of relative pointers and other fields they wouldn't necessarily be the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77592/new/

https://reviews.llvm.org/D77592