[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

Sun Jun 14 08:01:00 PDT 2020

lebedev.ri added a comment.

In D81336#2091833 <https://reviews.llvm.org/D81336#2091833>, @aaron.ballman wrote:

> In D81336#2090708 <https://reviews.llvm.org/D81336#2090708>, @LegalizeAdulthood wrote:
>
> > Yeah, the restriction to the header file is a bug.  It was a misconception on my part when I originally wrote the matcher.
>
>
> Excellent, thank you for weighing in! I'm fine with the original version of the patch going in with that modification if you'd like to go that route.
>
> In D81336#2078669 <https://reviews.llvm.org/D81336#2078669>, @steveire wrote:
>
> > This isn't needed if https://reviews.llvm.org/D80961 is merged.
>
>
> Alternatively, I would be fine waiting until that review is merged and making only the main file expansion fixes.

It may be better to not wait for larger refactoring but handle known false-positive immediately.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81336/new/

https://reviews.llvm.org/D81336