[PATCH] D81422: Change filecheck default to dump input on failure
Joel E. Denny via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 12 13:08:18 PDT 2020
jdenny added a comment.
In D81422#2090425 <https://reviews.llvm.org/D81422#2090425>, @mehdi_amini wrote:
> I'm thinking about a possible improvement here: we could have FileCheck dump the input for the current CHECK-LABEL section only: it seems like it could reduce the output drastically while still preserving how useful the information is?
One FileCheck invocation can report multiple errors, one per CHECK-LABEL section, and I prefer to see all errors every time.
I also prefer to see the entire input dump (with annotations produced by -vv) as sometimes the error FileCheck reports is far away from the actual error. For example, maybe the CHECK-LABEL directives matched text at unexpected locations in the input, and then the directives in their sections failed as a result. It might be hard to determine that the CHECK-LABEL directives were at fault without seeing the text it should have matched outside of its (incorrect) section.
If you choose to limit the dump to one CHECK-LABEL section, please make that behavior optional via a command-line option (which can be set via FILECHECK_OPTS).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81422/new/
https://reviews.llvm.org/D81422
More information about the cfe-commits
mailing list