[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

Richard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 12 13:42:18 PDT 2020


LegalizeAdulthood added a comment.

Yeah, the restriction to the header file is a bug.  It was a misconception on my part when I originally wrote the matcher.

See https://bugs.llvm.org/show_bug.cgi?id=26332 which should also be fixed by the change here.

I had attempted to make progress on fixing that bug (26332) but some retooling of the testing framework is needed to validate
that the **header** has a fixit applied to it.  I made some progress by refactoring the python script, but as usual it got bogged
down in clang review hell and I haven't had time to make any more forward progress on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81336/new/

https://reviews.llvm.org/D81336





More information about the cfe-commits mailing list