[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 12 13:08:32 PDT 2020


yaxunl added a comment.

In D81627#2090499 <https://reviews.llvm.org/D81627#2090499>, @tra wrote:

> LGTM.  Good to go if @arsenm is OK with fixing -fgpu-rdc in a separate patch.


@arsenm Are you OK with fixing -fgpu-rdc in a separate patch? The fix for that is orthogonal to the current patch. Mixing them together will clutter things up. Also the need for -fgpu-rdc is not so urgent since only rccl needs it. Requesting this patch to fix -fgpu-rdc will delay fixing issues for all other math libs and frameworks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81627/new/

https://reviews.llvm.org/D81627





More information about the cfe-commits mailing list