[PATCH] D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible()

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

In D81392#2089251 <https://reviews.llvm.org/D81392#2089251>, @mboehme wrote:

> In D81392#2088131 <https://reviews.llvm.org/D81392#2088131>, @rsmith wrote:
>
> > Maybe we should dump the ModuleOwnershipKind in general, not only an indicator of whether it's Visible or something else?
>
>
> I like this -- though would we then always dump the ModuleOwnershipKind (i.e. causing a lot of churn, as discussed above) or only if it's `VisibleWhenImported` or `ModulePrivate` (i.e. not unconditionally visible)?


I think only producing output for the "non-default" state (not Visible) would be best, both too minimize the test churn and to keep the dump smaller and simpler in simple cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81392/new/

https://reviews.llvm.org/D81392