[PATCH] D81242: [StackSafety] Run ThinLTO
Vitaly Buka via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 12 02:08:09 PDT 2020
vitalybuka added inline comments.
================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618
+ ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth());
+ if (Access.signedAddMayOverflow(C.Offset) !=
+ ConstantRange::OverflowResult::NeverOverflows)
----------------
eugenis wrote:
> Do we have a test for this overflow check?
yes
Example, in bit width 8
[-128,-127)+[-128,-127) = [0,1)
both non-wrapped and result is non-wrapped so we have no way to spot overflow
================
Comment at: llvm/test/Analysis/StackSafetyAnalysis/ipa-alias.ll:55
+; RUN: -r %t.summ1.bc,Write1,px 2>&1 | FileCheck %s --check-prefixes=CHECK,GLOBAL,LTO
+
target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
----------------
eugenis wrote:
> For my education - how do you come up with these symbol lists?
it complains about each missing <obj, symbol> pair
then flags guess and try
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81242/new/
https://reviews.llvm.org/D81242
More information about the cfe-commits
mailing list