[PATCH] D81688: [WebAssembly] WebAssembly doesn't support "protected" visibility

[Sam Clegg via Phabricator via cfe-commits]

sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Basic/Targets/WebAssembly.h:139
+    // Emscripten targets.
+    return getTriple().isOSEmscripten();
+  }
----------------
I'm not sure we need this compatibility.  For sure we don't implement any special behaviour based on this value I'm not sure if we want to warn either.

For now I guess this a conservative choice, but we we should try to replace with with simply `return false` in the future.

Perhaps you could update the comment to be more like a TODO?  lgtm either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81688/new/

https://reviews.llvm.org/D81688