[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 11 17:38:44 PDT 2020


rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Sema/SemaTemplate.cpp:1967
+        TransformType(InnerTLB, OrigDecl->getTypeSourceInfo()->getTypeLoc());
+    TypeSourceInfo *TSI = Context.getTrivialTypeSourceInfo(Transformed);
+
----------------
Retaining the location information here would be good too. (You already have that location info in `InnerTLB`.) I think there might even be a convenience `TypeSourceInfo` -> `TypeSourceInfo` transform you can invoke here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80743/new/

https://reviews.llvm.org/D80743





More information about the cfe-commits mailing list