[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

[Benson Chu via Phabricator via cfe-commits]

pestctrl marked an inline comment as done.
pestctrl added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6451
+  "%1 is %select{|in}3complete">,
+  InGroup<C99Compat>;
 def ext_typecheck_ordered_comparison_of_function_pointers : ExtWarn<
----------------
rsmith wrote:
> pestctrl wrote:
> > efriedma wrote:
> > > `InGroup<C11>`
> > Sorry, I'm not sure I understand. Isn't this a C99 warning? Why is it being put in the C11 group?
> Because `C11` really means `C11Extensions`, and this is a C11 extension (ie, it's code that's valid in C11 but not valid in C99):
> ```
> // A warning group for warnings about using C11 features as extensions.
> def C11 : DiagGroup<"c11-extensions">;
> ```
Got it, thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79945/new/

https://reviews.llvm.org/D79945