[PATCH] D81420: Fix size for _ExtInt types with builtins

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 11 06:35:17 PDT 2020


erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

Feel free to simplify the error message on commit.



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7940
+def err_overflow_builtin_ext_int_max_size : Error<
+  "__builtin_mul_overflow does not support %select{signed|unsigned}0 _ExtInt "
+  "operands of more than %1 bits">;
----------------
I don't think it is worth doing a 'select' on signed/unsigned.  When we need it, we can add it.

I more expect the builtin name to be modified first though (but don't bother making it a modifyable either).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81420/new/

https://reviews.llvm.org/D81420





More information about the cfe-commits mailing list