[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the PCH

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 10 16:42:10 PDT 2020


rsmith added a comment.

In D77194#2086245 <https://reviews.llvm.org/D77194#2086245>, @sammccall wrote:

> @rsmith are you OK with merging this into the release branch for 10.0.1?
>  cc @tstellar


Yes, please do.

(I would like for us to eventually maintain AST file format compatibility between patch releases, which this change would break, but as far as I'm aware the status quo is still that we include the version number and revision as part of the signature of the AST file and will reject the file if it differs even by clang patch release, so the compatibility there is only a future-facing concern, not one that affects this change.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77194/new/

https://reviews.llvm.org/D77194





More information about the cfe-commits mailing list