[PATCH] D81420: Fix size for _ExtInt types with builtins

Mott, Jeffrey T via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 10 16:42:09 PDT 2020


jtmott-intel updated this revision to Diff 269995.
jtmott-intel added a comment.

This updated patch prepared before John's latest comments.

- Changed diagnostic message to something halfway between John and Erich's suggestions.
- Removed superfluous calls to Arg.get.
- Combined call to Diag and return of error status.
- Simplified but kept ternary (for now).
- Updated comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81420/new/

https://reviews.llvm.org/D81420

Files:
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/lib/CodeGen/CGBuiltin.cpp
  clang/lib/Sema/SemaChecking.cpp
  clang/test/CodeGen/builtins-overflow.c
  clang/test/Sema/builtins-overflow.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81420.269995.patch
Type: text/x-patch
Size: 8011 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200610/eabb207b/attachment.bin>


More information about the cfe-commits mailing list