[PATCH] D81564: [analyzer] SATest: Add posibility to download source from git and zip

Valeriy Savchenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 10 11:08:00 PDT 2020


vsavchenko marked an inline comment as done.
vsavchenko added inline comments.


================
Comment at: clang/utils/analyzer/ProjectMap.py:14
 
+class DownloadType(str, Enum):
+    GIT = "git"
----------------
xazax.hun wrote:
> I was wondering what is the point of inheriting from `str`. I am not well-versed in Python so it is more of a curiosity.
It helps with direct assignments from strings, cross-comparisons between `Enum` values and strings, and most importantly - serialization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81564/new/

https://reviews.llvm.org/D81564





More information about the cfe-commits mailing list