[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests
    Sander de Smalen via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Wed Jun 10 04:52:54 PDT 2020
    
    
  
sdesmalen added inline comments.
================
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_abd.c:6
 
+// ASM-NOT: warning
 #include <arm_sve.h>
----------------
Just thinking out loud here; we don't need to test for the specific warnings, because LLVM doesn't emit any other warnings and any Clang's warnings are otherwise caught by `-Werror`.
================
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_abd.c:6
 
+// ASM-NOT: warning
 #include <arm_sve.h>
----------------
sdesmalen wrote:
> Just thinking out loud here; we don't need to test for the specific warnings, because LLVM doesn't emit any other warnings and any Clang's warnings are otherwise caught by `-Werror`.
Can you add a comment to these checks, so that if someone breaks it (because their code causes a new warning), they know where to look?
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80712/new/
https://reviews.llvm.org/D80712
    
    
More information about the cfe-commits
mailing list