[PATCH] D81422: Change filecheck default to dump input on failure

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

In D81422#2083808 <https://reviews.llvm.org/D81422#2083808>, @mehdi_amini wrote:

> In D81422#2083761 <https://reviews.llvm.org/D81422#2083761>, @arsenm wrote:
>
> > I think this is a worse default for development for large tests.
>
>
> Maybe the issue is with large tests that needs to be broken up?


This isn't really manageable, especially with the trend of using update_* test checks scripts. Stuff like legalization tests just have to stress every combination of inputs. The -dump-input-on-failure could also be smarter about how much context it prints

> To me this is a general improvement during development at my desk and reading a test output to understand the failure: this goes beyond build bots.
> 
> (you have the environment variable you can set locally if you don't want the behavior though)

The environment variable was removed though? I would also at least expect this to be an option I can set at cmake time and never have to think about again


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81422/new/

https://reviews.llvm.org/D81422