[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

Tue Jun 9 22:01:47 PDT 2020

baloghadamsoftware added a comment.

In D80286#2083753 <https://reviews.llvm.org/D80286#2083753>, @saugustine wrote:

> Unfortunately, after this change there are several variables only used in asserts, which creates build failures when assertions are disabled.
>
> I will be submitting https://reviews.llvm.org/D81522 shortly to fix.

What is the point of building unit tests with assertions disabled? To me this looks like a `CMake` configuration problem. Unit tests should always be built with assertions enabled since they are based on assertions. They are just tests, they do not decrease the performance of the production code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80286/new/

https://reviews.llvm.org/D80286