[PATCH] D81479: [BPF] introduce __builtin_load_u32_to_ptr() intrinsic

Yonghong Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 9 16:04:32 PDT 2020


yonghong-song added a comment.

In D81479#2083510 <https://reviews.llvm.org/D81479#2083510>, @anakryiko wrote:

> IntrinsicsBPF.td uses `__builtin_bpf_load_u32_to_ptr`, while everywhere it is just `__builtin_load_u32_to_ptr`. I think having bpf prefix there is good, given this is bpf-specific. But either way, probably should be consistent everywhere?


Sounds good. This is indeed specific to bpf, adding bpf prefix to the public builtin name sounds reasonable.  Will make the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81479/new/

https://reviews.llvm.org/D81479





More information about the cfe-commits mailing list