[libunwind] 168681a - [libc++abi][libunwind] Don't override libc++'s handling of exception features

Louis Dionne via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 9 13:03:35 PDT 2020


Author: Louis Dionne
Date: 2020-06-09T16:03:22-04:00
New Revision: 168681abce63d9cc0cec24cfc1d0caef6fa3a25f

URL: https://github.com/llvm/llvm-project/commit/168681abce63d9cc0cec24cfc1d0caef6fa3a25f
DIFF: https://github.com/llvm/llvm-project/commit/168681abce63d9cc0cec24cfc1d0caef6fa3a25f.diff

LOG: [libc++abi][libunwind] Don't override libc++'s handling of exception features

0e04342ae039 simplified exceptions-related configurations for libc++abi
and libunwind by reusing the logic in libc++. However, it missed the fact
that libc++abi and libunwind were overriding libc++'s handling of exceptions.

This commit removes special handling in libc++abi and libunwind to use
the logic in libc++, which is the right one.

Added: 
    

Modified: 
    libcxxabi/test/libcxxabi/test/config.py
    libunwind/test/libunwind/test/config.py

Removed: 
    


################################################################################
diff  --git a/libcxxabi/test/libcxxabi/test/config.py b/libcxxabi/test/libcxxabi/test/config.py
index f1eb453e09f3..37938d53a240 100644
--- a/libcxxabi/test/libcxxabi/test/config.py
+++ b/libcxxabi/test/libcxxabi/test/config.py
@@ -86,8 +86,5 @@ def configure_compile_flags_header_includes(self):
                                       % libunwind_headers)
             self.cxx.compile_flags += ['-I' + libunwind_headers]
 
-    def configure_compile_flags_exceptions(self):
-        pass
-
     def configure_compile_flags_rtti(self):
         pass

diff  --git a/libunwind/test/libunwind/test/config.py b/libunwind/test/libunwind/test/config.py
index 7e4f230d821c..31f6148879c5 100644
--- a/libunwind/test/libunwind/test/config.py
+++ b/libunwind/test/libunwind/test/config.py
@@ -59,9 +59,6 @@ def configure_compile_flags_header_includes(self):
                                   % libunwind_headers)
         self.cxx.compile_flags += ['-I' + libunwind_headers]
 
-    def configure_compile_flags_exceptions(self):
-        pass
-
     def configure_compile_flags_rtti(self):
         pass
 


        


More information about the cfe-commits mailing list