[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

Anatoly Trosinenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 9 09:19:36 PDT 2020


atrosinenko added inline comments.


================
Comment at: compiler-rt/lib/builtins/int_lib.h:112
 
-uint32_t __inline __builtin_ctz(uint32_t value) {
+int __inline __builtin_ctz(uint32_t value) {
   unsigned long trailing_zero = 0;
----------------
aykevl wrote:
> Why `int` and not `native_int` here?
Just to use more "textually identical" prototype as for an actual `__builtin_ctz` from GCC. On the other hand, such dilemma could be one of arguments against `native_int`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81285/new/

https://reviews.llvm.org/D81285





More information about the cfe-commits mailing list