[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

[Whisperity via Phabricator via cfe-commits]

whisperity added inline comments.


================
Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:119-120
+      return "Invocation list file contains multiple references to the same "
+             "source"
+             " file.";
+    case index_error_code::invocation_list_file_not_found:
----------------
These two lines could be formatted together.


================
Comment at: clang/unittests/CrossTU/CrossTranslationUnitTest.cpp:233
+  EXPECT_EQ(It->getValue()[4], "/tmp/other.cpp");
 }
 
----------------
Just for good measure, I would like a test case on the "invocation list is ambiguous" error. (So in case we in the future figure out how to disambiguate, we can remove that test case!)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75665/new/

https://reviews.llvm.org/D75665