[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

Sam McCall via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 9 06:44:56 PDT 2020


I've reverted it...
Had written the trivial fix to the test but actually this should work - a
delayed templates in the preamble and eager templates in the main file is
what we use in production on windows.
This seems like a clang bug, maybe an interaction with skip function bodies.

On Tue, Jun 9, 2020 at 3:33 PM Nico Weber via Phabricator <
reviews at reviews.llvm.org> wrote:

> thakis added a comment.
>
> Breaks tests on windows: http://45.33.8.238/win/17229/step_9.txt
>
> Please take a look and revert if it takes a while to fix. (Might just be
> the usual delayed template parsing thing.)
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D81351/new/
>
> https://reviews.llvm.org/D81351
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200609/84f73cc1/attachment.html>


More information about the cfe-commits mailing list