[PATCH] D81422: Change filecheck default to dump input on failure

Mehdi AMINI via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 8 18:50:27 PDT 2020


mehdi_amini added inline comments.


================
Comment at: llvm/test/FileCheck/dump-input-enable.txt:78
 ; Check no -dump-input, which defaults to never.
 ;--------------------------------------------------
 
----------------
jdenny wrote:
> Are the tests in this section passing for you now that the default is fail?
Now they do :)
I originally pushed to Phab to get the pre-merge testing running while I was still fixing a few things locally, I didn't expect such fast reviews!
Should be all good now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81422/new/

https://reviews.llvm.org/D81422





More information about the cfe-commits mailing list