[PATCH] D81422: Change filecheck default to dump input on failure

Mehdi AMINI via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 8 13:52:09 PDT 2020


mehdi_amini added a comment.

In D81422#2080758 <https://reviews.llvm.org/D81422#2080758>, @probinson wrote:

> I don't remember the exact reasoning but I believe it had something to do with bot logs?  @jdenny or @thopre might remember.


It'd be interesting to hear about it: having the bot log including the input on failure could indeed help debugging when something fails in flaky way, or is dependent on the environment (like the path where the code is checked out, etc.). 
At least in the past it could have saved me trouble when only a single bot was failing in mysterious way and the bot owner had to be involved to help figure out.

(also right now we're inconsistent: many tests are adding the flag explicitly)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81422/new/

https://reviews.llvm.org/D81422





More information about the cfe-commits mailing list